refactor: extract shared clipboard module from webidl-clipboard#5202
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the existing WebIDL copy-to-clipboard button implementation by extracting the shared copy button creation/copy logic into a reusable core/clipboard.js module, enabling reuse by other code block processors (e.g., upcoming CDDL support).
Changes:
- Introduces
src/core/clipboard.jswith a sharedcreateCopyButton(headerSelector)helper. - Updates
src/core/webidl-clipboard.jsto delegate tocreateCopyButton(".idlHeader").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/core/webidl-clipboard.js | Replaces inline copy-button creation/copy logic with a call to the shared helper. |
| src/core/clipboard.js | Adds a shared copy-button factory and click handler that copies <pre> contents excluding a header element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move the copy button creation and SVG into a shared clipboard.js module. webidl-clipboard.js now delegates to createCopyButton() with ".idlHeader" as the header selector. This prepares for CDDL and other code block types to reuse the same copy functionality.
marcoscaceres
force-pushed
the
refactor/clipboard-shared
branch
from
ac725c2 to
24f9760
Compare
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Lgtm. Let's use copilot suggestion to add aria-label though. Rest is good.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Addressed in The shared copy button now sets Screenshot: |
Summary
webidl-clipboard.jsinto a sharedclipboard.jsmodulewebidl-clipboard.jsnow delegates tocreateCopyButton(".idlHeader")Split out from #5201 per Sid's request.
Test plan
Modified Web platform tests— no observable behavior change (pure refactor)